Skip to content

Add KID check when getting a token from cache #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JorgeDaboub wants to merge 2 commits into from
Closed

Add KID check when getting a token from cache #692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac52dce
Add KID check when getting a token from cache
JorgeDaboub Apr 26, 2024
d9722f1
update telemetry value
JorgeDaboub Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions msal/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,6 +1386,9 @@ def _acquire_token_silent_from_cache_and_possibly_refresh_it(
if expires_in < 5*60: # Then consider it expired
refresh_reason = msal.telemetry.AT_EXPIRED
continue # Removal is not necessary, it will be overwritten
if key_id and entry.get("key_id") != key_id:
refresh_reason = msal.telemetry.AT_ABSENT
continue # If the Key_Id is not matching, then it is not the token we are looking for
logger.debug("Cache hit an AT")
access_token_from_cache = { # Mimic a real response
"access_token": entry["secret"],
Expand Down