test(cssc): 30926545 add Scenario test for extension, fix style issues (2/n)#25
Merged
Merged
Conversation
cegraybl
force-pushed
the
cegraybl/cssc_30926545_unittest_2
branch
from
e892deb to
509c158
Compare
Merged
9 tasks
cegraybl
changed the title
cegraybl
force-pushed
the
cegraybl/cssc_30926545_unittest_2
branch
from
2ff7690 to
1a5143a
Compare
There was a problem hiding this comment.
PR Overview
This PR adds a new scenario test for the CSSC extension while addressing remaining style, lint, and versioning issues for a private preview release.
- Added scenario and unit tests for CSSC functionality
- Updated parameter handling and user confirmation in delete commands
- Adjusted version and metadata details in setup.py
Reviewed Changes
| File | Description |
|---|---|
| tests/latest/test_cssc_scenario.py | Added new scenario test for CSSC workflow |
| tests/latest/test_cssc.py | Added unit tests for CSSC operations |
| _params.py | Updated argument context for delete command with user confirmation flag |
| tests/latest/test_helper_taskoperations.py | Updated test cases to use class-level cmd and registry |
| setup.py | Updated version number and metadata details |
| cssc.py | Added new parameter 'yes' to delete command and updated confirmation call |
| helper/_ociartifactoperations.py | Improved temporary file cleanup check |
| helper/_workflow_status.py | Refactored function signatures and formatting in log polling |
| helper/_taskoperations.py | Removed redundant cmd argument from update functions |
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/acrcssc/azext_acrcssc/helper/_taskoperations.py:135
- If one task deletion fails, subsequent deletions will be skipped. Consider wrapping each _delete_task call inside its own try/except block to ensure all deletions are attempted.
# bug: if one of the deletion fails, the others will not be attempted, we need to attempt to delete all of them
huanwu
reviewed
Mar 10, 2025
Ruchii-27
reviewed
Mar 10, 2025
cegraybl
added a commit
that referenced
this pull request
Apr 23, 2025
…s (2/n) (#25) - Add ScenarioTest for the extension and the recording - Fix remaining style and lint issues - Fix README file to reflect basic usage - Fix HISTORY and setup.py to have the final release version for private preview
cegraybl
added a commit
that referenced
this pull request
Apr 24, 2025
…s (2/n) (#25) - Add ScenarioTest for the extension and the recording - Fix remaining style and lint issues - Fix README file to reflect basic usage - Fix HISTORY and setup.py to have the final release version for private preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.