fix(cssc): 31694219 inform user when images matching their configuration are 0#30
Merged
Merged
Conversation
huanwu
reviewed
Mar 8, 2025
cegraybl
reviewed
Mar 10, 2025
cegraybl
approved these changes
Mar 10, 2025
huanwu
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During dry-run, we inform the user if images matching their configuration = 0.
However, currently, during actual create/update, this information is lost.
With this fix, I am basically matching up the dry-run and actual run logs by relaying this information to the user.
Intentionally not blocking the create/update operation - for the scenarios when user wants to create the patching workflow first and later wants to push relevant images.
Bug - https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31694219/?view=edit
Behavior after fix on Update...
Behavior after fix on Create..
