fix(cssc): 31250186 address partial comments in public repo PR 20250415#46
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (3)
- src/acrcssc/README.rst: Language not supported
- src/acrcssc/azext_acrcssc/azext_metadata.json: Language not supported
- src/acrcssc/azext_acrcssc/templates/acrcli/artifact.json: Language not supported
Comments suppressed due to low confidence (3)
src/acrcssc/azext_acrcssc/helper/_workflow_status.py:207
- [nitpick] Verify that 'repository' and 'patched_tag' are not empty strings in addition to being non-null. If empty strings are valid inputs, consider using an explicit check to avoid unexpected behavior.
if repository and patched_tag:
src/acrcssc/azext_acrcssc/helper/_workflow_status.py:288
- Ensure that the '_latest_task' function returns exactly two values for proper tuple unpacking. Adjust the return values or unpacking logic if this assumption does not hold.
all_status[image].scan_task, all_status[image].scan_logs = WorkflowTaskStatus._latest_task(...
src/acrcssc/azext_acrcssc/helper/_ociartifactoperations.py:95
- Ensure that 'oras_client' is defined before reaching the 'finally' block to avoid a potential NameError if an exception occurs prior to its initialization.
if oras_client:
cegraybl
added a commit
that referenced
this pull request
Apr 23, 2025
…15 (#46) Address a partial list of PR comments on the public PR: Azure#8530 Rest of comments require additional consideration.
cegraybl
added a commit
that referenced
this pull request
Apr 24, 2025
…15 (#46) Address a partial list of PR comments on the public PR: Azure#8530 Rest of comments require additional consideration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address a partial list of PR comments on the public PR: Azure#8530
Rest of comments require additional consideration.