Skip to content

fix(cssc): 31250186 address comments on versioning #8690#56

Merged
cegraybl merged 3 commits into
feature/cssc_extfrom
cegraybl/pr_comments_9
Apr 25, 2025
Merged

fix(cssc): 31250186 address comments on versioning #8690#56
cegraybl merged 3 commits into
feature/cssc_extfrom
cegraybl/pr_comments_9

Conversation

@cegraybl
Copy link
Copy Markdown

  • Fix versioning used in HISTORY to reflect final version used in preview (1.0.0b1)
  • change resource group parameter to use resource_group_name_type from azure.cli.core.commands.parameters

@cegraybl cegraybl requested a review from Copilot April 25, 2025 16:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the resource group parameter for the ACR supply-chain workflow command and adjusts import statements accordingly.

  • Updates import to include resource_group_name_type
  • Adjusts the definition of the resource_group argument to leverage resource_group_name_type
Files not reviewed (1)
  • src/acrcssc/HISTORY.rst: Language not supported
Comments suppressed due to low confidence (1)

src/acrcssc/azext_acrcssc/_params.py:22

  • The explicit help message and options previously provided for the 'resource_group' parameter are removed. Verify that resource_group_name_type encapsulates the necessary CLI argument metadata (such as help text and alias options) to maintain intended usability.
c.argument('resource_group', resource_group_name_type, completer=get_resource_name_completion_list(REGISTRY_RESOURCE_TYPE))

@cegraybl cegraybl requested a review from Copilot April 25, 2025 17:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the versioning in HISTORY to reflect the final preview version and refactors the resource group parameter in the CLI by switching to the resource_group_name_type parameter.

  • Updated HISTORY versioning to 1.0.0b1
  • Replaced explicit resource group parameter definitions with resource_group_name_type to standardize parameter configuration
Files not reviewed (1)
  • src/acrcssc/HISTORY.rst: Language not supported
Comments suppressed due to low confidence (1)

src/acrcssc/azext_acrcssc/_params.py:22

  • Verify that resource_group_name_type encapsulates all necessary metadata (such as options_list and help message) from the previous implementation to maintain consistent CLI behavior.
c.argument('resource_group', arg_type=resource_group_name_type, completer=get_resource_name_completion_list(REGISTRY_RESOURCE_TYPE))

@cegraybl cegraybl merged commit f5612d4 into feature/cssc_ext Apr 25, 2025
@cegraybl cegraybl deleted the cegraybl/pr_comments_9 branch April 25, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants