fix(cssc): 31250186 address comments on versioning #8690#56
Merged
Conversation
cegraybl
commented
Apr 25, 2025
- Fix versioning used in HISTORY to reflect final version used in preview (1.0.0b1)
- change resource group parameter to use resource_group_name_type from azure.cli.core.commands.parameters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the resource group parameter for the ACR supply-chain workflow command and adjusts import statements accordingly.
- Updates import to include resource_group_name_type
- Adjusts the definition of the resource_group argument to leverage resource_group_name_type
Files not reviewed (1)
- src/acrcssc/HISTORY.rst: Language not supported
Comments suppressed due to low confidence (1)
src/acrcssc/azext_acrcssc/_params.py:22
- The explicit help message and options previously provided for the 'resource_group' parameter are removed. Verify that resource_group_name_type encapsulates the necessary CLI argument metadata (such as help text and alias options) to maintain intended usability.
c.argument('resource_group', resource_group_name_type, completer=get_resource_name_completion_list(REGISTRY_RESOURCE_TYPE))
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the versioning in HISTORY to reflect the final preview version and refactors the resource group parameter in the CLI by switching to the resource_group_name_type parameter.
- Updated HISTORY versioning to 1.0.0b1
- Replaced explicit resource group parameter definitions with resource_group_name_type to standardize parameter configuration
Files not reviewed (1)
- src/acrcssc/HISTORY.rst: Language not supported
Comments suppressed due to low confidence (1)
src/acrcssc/azext_acrcssc/_params.py:22
- Verify that resource_group_name_type encapsulates all necessary metadata (such as options_list and help message) from the previous implementation to maintain consistent CLI behavior.
c.argument('resource_group', arg_type=resource_group_name_type, completer=get_resource_name_completion_list(REGISTRY_RESOURCE_TYPE))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.