Skip to content

[SUPPORT-14096] Fix Nieuwe PKIoverheid certificaten worden niet vertrouwd door Apache CXF #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mprins merged 2 commits into from
Jan 11, 2024
Merged

[SUPPORT-14096] Fix Nieuwe PKIoverheid certificaten worden niet vertrouwd door Apache CXF #2007

mprins merged 2 commits into from
Jan 11, 2024

Conversation

@matthijsln
Copy link
Member

@matthijsln matthijsln commented Jan 9, 2024 •
edited by mprins
Loading

resolve SUPPORT-14096

@matthijsln matthijsln requested a review from mprins January 9, 2024 16:48
@matthijsln matthijsln self-assigned this Jan 9, 2024
@matthijsln matthijsln changed the title Fix PKIoverheid certificates were not trusted using CXF Fix PKIoverheid certificates were not trusted by CXF Jan 9, 2024
@matthijsln matthijsln enabled auto-merge January 9, 2024 16:57
@codecov
Copy link

codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9748369) 37% compared to head (090c522) 37%.
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #2007    +/-   ##
=========================================
+ Coverage        37%     37%    +1%     
- Complexity      810     948   +138     
=========================================
  Files           415     415            
  Lines         21200   21199     -1     
  Branches       2007    2007            
=========================================
  Hits           7782    7782            
+ Misses        12800   12799     -1     
  Partials        618     618
Files Coverage Δ
...nl/b3p/brmo/service/scanner/GDS2OphalenProces.java 0% <0%> (ø)

@mprins mprins changed the title Fix PKIoverheid certificates were not trusted by CXF [SUPPORT-14096] Fix PKIoverheid certificates were not trusted by CXF Jan 11, 2024
@mprins mprins changed the title [SUPPORT-14096] Fix PKIoverheid certificates were not trusted by CXF [SUPPORT-14096] Fix Nieuwe PKIoverheid certificaten worden niet vertrouwd door Apache CXF Jan 11, 2024
mprins
mprins reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probleem dook al eerder op bij upgrade van CXF #1850 dus mogelijk kunnen we nu wel cxf upgraden naar 3.6.2

@mprins mprins disabled auto-merge January 11, 2024 12:36
@mprins mprins added the dependency update (deels) automatische updates van gebruikte libraries label Jan 11, 2024
@mprins mprins merged commit ebd263e into master Jan 11, 2024
@mprins mprins deleted the fix-cxf-ssl-trust branch January 11, 2024 12:37
@matthijsln
Copy link
Member Author

matthijsln commented Jan 11, 2024

probleem dook al eerder op bij upgrade van CXF #1850 dus mogelijk kunnen we nu wel cxf upgraden naar 3.6.2

ah ja dus al eerder tegengekomen, gek dat vorige versie van CXF blijkbaar wel werkte met de TrustManagers van de SSLContext.

@mvdstruijk mvdstruijk mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mprins mprins mprins approved these changes

Assignees

@matthijsln matthijsln

Labels

BRK brmo-service bug dependency update (deels) automatische updates van gebruikte libraries regressie

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthijsln @mprins