Fix: 중복 검사 해결 #354
Merged
Fix: 중복 검사 해결 #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choi-JJunho
requested changes
Mar 17, 2024
Member
Choi-JJunho
left a comment
Choi-JJunho
left a comment
There was a problem hiding this comment.
race condition.. 클라이언트에서 디바운싱으로 막아주면 더 좋겠네요
코멘트 하나만 확인해주세용
Comment on lines
156
to
164
| // redisOwnerMapper.validateOwner(ownerEmailAddress, ownerAuthPrefix); | ||
|
|
||
| encodePassword(owner); | ||
|
|
||
| createInDBFor(owner); | ||
|
|
||
| slackNotiSender.noticeRegisterComplete(owner); | ||
|
|
||
| redisOwnerMapper.removeRedisFrom(ownerEmailAddress, ownerAuthPrefix); | ||
| // redisOwnerMapper.removeRedisFrom(ownerEmailAddress, ownerAuthPrefix); |
Member
There was a problem hiding this comment.
이 친구들 주석으로 남긴 이유가 있을까요?
주석이 된 사유라도 남겨주면 좋겠네요
Collaborator
johnny19991006
left a comment
johnny19991006
left a comment
There was a problem hiding this comment.
나머지 바뀐 코드들은 컨벤션 문제로 바뀐건지 한번 체크해주세요~
Comment on lines
313
to
315
| } catch (DuplicateKeyException e | ||
| ) { | ||
| throw new BaseException(ExceptionInformation.EMAIL_DUPLICATED); |
Collaborator
There was a problem hiding this comment.
여기Key중복 되었을떄의 Exception처리가 되었네요 Good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
▶ Request
Content
#353
as-is
to-be
✅ Check List
pom.xml) 변경이 일어나지 않았는지📸 API Document ScreenShot
🧪 Test