-
Notifications
You must be signed in to change notification settings - Fork 2
fix: 코인 어드민 API 수정 #2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: 코인 어드민 API 수정 #2140
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d5a0040
feat: CreateAdminRequest JsonProperty 어노테이션 적용
Soundbar91 4b2948d
docs: 어드민 회원가입 API 설명 추가
Soundbar91 4c46564
fix: PUT /admin/{id}/authed 권한 수정
Soundbar91 2183abc
fix: PUT /admin/{id}/authed 요청 바디 추가 및 내부 로직 수정
Soundbar91 4d5ab73
feat: AdminUpdateRequest JsonProperty 적용
Soundbar91 400dcbe
fix: TeamType 삭제
Soundbar91 56f0bb7
fix: canCreateAdmin 삭제
Soundbar91 0ed40a6
fix: AdminResponse 응답값 수정
Soundbar91 ff34633
fix: AdminsResponse 응답값 수정
Soundbar91 b021e5c
feat: 어드민 계정 생성 이벤트 로직 추가
Soundbar91 830c33c
test: 테스트 수정
Soundbar91 09343e6
feat: 어드민 인증 상태 이벤트 알림 추가
Soundbar91 b257f37
chore: 주석 작성
Soundbar91 4231a16
fix: 코인 어드민 계정 생성 권한값 수정
Soundbar91 8a25d82
Merge branch 'develop' into fix/2139-koin-manager-api
Soundbar91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
...a/in/koreatech/koin/admin/manager/dto/request/AdminAuthenticationStatusUpdateRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package in.koreatech.koin.admin.manager.dto.request; | ||
|
|
||
| import static com.fasterxml.jackson.databind.PropertyNamingStrategies.SnakeCaseStrategy; | ||
| import static io.swagger.v3.oas.annotations.media.Schema.RequiredMode.REQUIRED; | ||
|
|
||
| import com.fasterxml.jackson.databind.annotation.JsonNaming; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import jakarta.validation.constraints.NotNull; | ||
|
|
||
| @JsonNaming(value = SnakeCaseStrategy.class) | ||
| public record AdminAuthenticationStatusUpdateRequest( | ||
| @Schema(description = "인증 상태", example = "true", requiredMode = REQUIRED) | ||
| @NotNull(message = "인증 상태는 필수 입력 사항입니다.") | ||
| Boolean isAuthed | ||
| ) { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
src/main/java/in/koreatech/koin/common/event/AdminAuthenticationStatusChangeEvent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package in.koreatech.koin.common.event; | ||
|
|
||
| public record AdminAuthenticationStatusChangeEvent( | ||
| String changedByAdminId, | ||
| String changedByAdminName, | ||
| String targetAdminId, | ||
| String targetAdminName, | ||
| Boolean isAuthed | ||
| ) { | ||
|
|
||
| } |
10 changes: 10 additions & 0 deletions
10
src/main/java/in/koreatech/koin/common/event/AdminRegisterEvent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package in.koreatech.koin.common.event; | ||
|
|
||
| public record AdminRegisterEvent( | ||
| String creatorId, | ||
| String creatorName, | ||
| String newAdminId, | ||
| String newAdminName | ||
| ) { | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
레거시 남겨놓은 이유가 있을까요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컬럼 drop이 지금 ci 과정에서 막히기도 하고, null값을 넣자하니 nullable이 아니기 때문에 수정해야하는데 nullable으로 수정할 바에 나중에 한번에 drop 하는게 편할 거 같아 유지했습니다.