Skip to content

105 fix 운영진 라벨 오표기 채팅방 뒤로가기 미작동 오류 수정#106

Merged
ff1451 merged 4 commits intodevelopfrom
105-fix-운영진-라벨-오표기-채팅방-뒤로가기-미작동-오류-수정
Feb 16, 2026

Hidden character warning

The head ref may contain hidden characters: "105-fix-\uc6b4\uc601\uc9c4-\ub77c\ubca8-\uc624\ud45c\uae30-\ucc44\ud305\ubc29-\ub4a4\ub85c\uac00\uae30-\ubbf8\uc791\ub3d9-\uc624\ub958-\uc218\uc815"
Merged

105 fix 운영진 라벨 오표기 채팅방 뒤로가기 미작동 오류 수정#106
ff1451 merged 4 commits intodevelopfrom
105-fix-운영진-라벨-오표기-채팅방-뒤로가기-미작동-오류-수정

Conversation

@ff1451
Copy link
Copy Markdown
Collaborator

@ff1451 ff1451 commented Feb 16, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed admin badge display to show only for club presidents.
    • Removed non-functional calendar management menu item.
    • Improved back navigation behavior for better user experience.

@ff1451 ff1451 self-assigned this Feb 16, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 16, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR updates club management and navigation features: removes the space from a membership position type literal, modifies badge display logic to show only for '회장' positions, removes an unused calendar icon and menu item, and simplifies navigation logic by removing conditional early returns.

Changes

Cohort / File(s) Summary
Position Type and Badge Display
src/apis/club/entity.ts, src/pages/Home/components/SimpleClubCard.tsx
Updated the JoinClub.position type from '일반 회원' to '일반회원' (removed space). Modified badge rendering logic to display "운영진" only when position is exactly '회장', instead of for any position not equal to the old string value.
Menu and Navigation Cleanup
src/pages/Manager/ManagedClubDetail/index.tsx, src/utils/hooks/useSmartBack.ts
Removed the CalendarDaysIcon import and unused menu item with empty path from ManagedClubDetail. Simplified useSmartBack hook by removing conditional early returns for /chats/ pathname and history.length checks, consolidating logic into a unified path-resolution flow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A little hop, a little change,
Position types rearranged,
Badges show for leaders true,
And navigation flows anew!
Fresh as carrots, clean and bright,
The code hops forward—all's just right! 🌱

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 105-fix-운영진-라벨-오표기-채팅방-뒤로가기-미작동-오류-수정

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ff1451 ff1451 merged commit 24152c4 into develop Feb 16, 2026
1 of 2 checks passed
@ff1451 ff1451 deleted the 105-fix-운영진-라벨-오표기-채팅방-뒤로가기-미작동-오류-수정 branch April 7, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] 운영진 라벨 오표기, 채팅방 뒤로가기 미작동 오류 수정

1 participant