Preserve opt-in prefix semantics in comparisons#2
Closed
Sagar Verma (ssagarverma) wants to merge 2 commits into
Closed
Preserve opt-in prefix semantics in comparisons#2Sagar Verma (ssagarverma) wants to merge 2 commits into
Sagar Verma (ssagarverma) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to hashicorp#79.
This stacks on top of
BESTSELLER/go-version:master, which is the current head branch for the upstream PR.Changes
NewVersionbehavior so arbitrary prefixed versions still fail without opt-inWithPrefixVersionCompareStrictto reject cross-prefix comparisons when both sides were created with explicit prefixesWhy
PR hashicorp#79 adds opt-in custom prefix parsing. This follow-up keeps the existing non-opt-in behavior strict while making cross-prefix matching explicit and test-covered.
Validation
go test ./...