Skip to content

Conversation

@GRamosPlux
Copy link

Dear @pires,
I truly hope that this message finds you well and facing exciting challenges in your projects!

During a support task involving the PLUX Support Team and a customer using this SDK, it was noticed that some sensor transfer functions were outdated.

Due to this circumstance, we decided to create this pull request (containing the updated transfer functions and unit tests) hoping that it can help the current and future members of your community!

My best and sincere regards,
GRamosPlux

@pires
Copy link
Contributor

pires commented Aug 26, 2021

Hey @GRamosPlux, thanks for the kind words and the PR. I too hope all is well w/ your and all your teammates at PLUX.

Copy link
Contributor

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I no longer have the means to test this but I trust you did. The code LGTM.

@pires
Copy link
Contributor

pires commented Aug 26, 2021

For anyone looking into this, it's been years since I did Java, so I don't even have a Maven/Gradle setup which I can use to release a new binary. I'm sorry!

@pires
Copy link
Contributor

pires commented Aug 26, 2021

Thanks you very much @GRamosPlux and PLUX.

@pires
Copy link
Contributor

pires commented Aug 26, 2021

Oh... seems I don't have write permissions on this repo so I can't merge :D

@GRamosPlux
Copy link
Author

Dear @pires,

Indeed, everything is well at PLUX, thank you very much for your attentive wishes and kind words!

Concerning the binary and the merge, there is no problem, I will talk with our team leader to overtake this obstacle ;-)
I am grateful for your valuable feedback and for the validation made to the current changes, through your code inspection.

In the meantime, we wish you a continuation of excellent work!

My best and sincere regards,
@GRamosPlux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants