-
Notifications
You must be signed in to change notification settings - Fork 9
Expand the functionality of the linked list #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| return null; | ||
| } | ||
| LinkedList.Circular.prototype.multiple = function(indexes) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest making sure that this method has a verb in the name (unless this name comes from a standard somewhere?). It's fairly clear what it does at the callsites, but it took a second to figure out what it did when I first saw this line. Something like getMultipleByIndex or something.
super-nitpicky optimization suggestions:
- construct the result array in the loop to remove the last line:
const result = [];
for (...) {
if (stuff) {
result.push(...);
}
}
return result;- use a
Setinstead ofMapto save a few array allocations - calculate the max index at the same time as populating the
Set
| } | ||
| } | ||
|
|
||
| LinkedList.Circular.prototype.indexOf = function(cb) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'm guessing this should be findIndex if you're wanting to keep aligned with the same naming as the array functions
|
While you're at it, maybe the linked list should be turned into a |
At the moment all iterations on playlist have to be done manually every time something is needed, creating unnecessary code duplication.
This pull request introduces methods on the linked list to unify these operations (ideally playlist would be an array).