Skip to content

Conversation

@Smidqe
Copy link
Contributor

@Smidqe Smidqe commented Sep 20, 2022

At the moment all iterations on playlist have to be done manually every time something is needed, creating unnecessary code duplication.

This pull request introduces methods on the linked list to unify these operations (ideally playlist would be an array).


return null;
}
LinkedList.Circular.prototype.multiple = function(indexes) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest making sure that this method has a verb in the name (unless this name comes from a standard somewhere?). It's fairly clear what it does at the callsites, but it took a second to figure out what it did when I first saw this line. Something like getMultipleByIndex or something.

super-nitpicky optimization suggestions:

  1. construct the result array in the loop to remove the last line:
const result = [];
for (...) {
  if (stuff) {
    result.push(...);
  }
}
return result;
  1. use a Set instead of Map to save a few array allocations
  2. calculate the max index at the same time as populating the Set

}
}

LinkedList.Circular.prototype.indexOf = function(cb) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm guessing this should be findIndex if you're wanting to keep aligned with the same naming as the array functions

@Atte
Copy link
Member

Atte commented Sep 20, 2022

While you're at it, maybe the linked list should be turned into a class instead of doing the prototype shenanigans?

@Smidqe Smidqe marked this pull request as draft April 20, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants