Cleanup unused global variables #113
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atte
requested changes
Sep 20, 2022
| start: function (event, ui) { | ||
| PLAYLIST_DRAGFROM = ui.item.index(); | ||
| PLAYLIST_DRAGSANITY = ui.item.data('plobject').videoid; | ||
| ui.item.parent().data('drag', { |
Member
There was a problem hiding this comment.
Couldn't this just use a local variable? Is there a benefit to storing the stuff in jQuery data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of global variables set in init.js haven't been in use in ages and have no apparent use anywhere. Same goes for main game functions, which have been superseded by the integration with teamup.
Playlist dragging globals too have no use outside of the sorting, and is changed to use the parent to store the information regarding the drag operation being performed.