Skip to content

Conversation

@Smidqe
Copy link
Contributor

@Smidqe Smidqe commented Sep 20, 2021

In order to prevent any breakage on the eve of anniversary games this pull request will stay as a draft until after it.

Reworked and made players into their own modules.

What's been tested:

  • Vimeo (+ their Live videos)
  • Youtube (not sure about premiers)
  • Dailymotion
  • File/raw (mp4, webm tested, m4v not)
  • Manifest's (mp4)
  • Twitch (live and with length both work)
  • Twitchclip
  • Soundcloud (
  • HLS (Is considered live, but can have defined length)
  • Dash
  • Osmf aka RTMP (requires flash). No compatible source, should be phased out

What's not been tested (don't have setup atm):

  • Needs more testing with berry

Additions:

  • Player modules
  • Ability for players to attempt to recover from error situations if possible
  • Ability to seek for Twitch videos if not a live video

Changes:

  • Switched from PLAYERS namespace to Players, not removing PLAYERS yet due to userspace (maltweaks) breaking
  • Reworked hbVideoDetail handling to remove duplication
  • Moved quality selection functions to File player and reworked them
  • Modified file player to not append extra dom elements and instead utilise src() function
  • Modified file player to allow another file/manifest video right after it
  • osmf, hls and dash players were integrated into file player and renamed file -> raw
  • From now on getTime() returns -1 if content is live or doesn't have length defined
  • Update DPM and videoBlacklist plugins to work with new players
  • Moved inlined CSS that some players used to layout-other.css

Removals:

  • Removed some unused global variables
  • Removed old player.js file
  • Removed removeCurrentPlayer in favor of player specific removals
  • Removed osmf, hls and dash players which were integrated into raw player

Notes:

  • In order to make maltweaks work there's a silly hack that fixes majority of the players in videoLoadAtTime() and we intentionally error maltweaks by not defining PLAYERS.dm, to prevent incorrect removal of dailymotion.
  • Enabling the raw players can break everything, so please dont.
  • Our support for HLS is incomplete and a video that has length is considered a livestream even though its not, the server is not syncing.

@Smidqe Smidqe force-pushed the refactor/player-modules branch from 6cefa41 to 00c9187 Compare September 20, 2021 11:52
@Smidqe Smidqe force-pushed the refactor/player-modules branch from ed23ebc to 2c661f8 Compare October 8, 2021 05:13
@Smidqe Smidqe marked this pull request as ready for review October 13, 2021 18:41
@Smidqe Smidqe marked this pull request as draft October 14, 2021 12:59
@Smidqe Smidqe marked this pull request as ready for review October 14, 2021 15:16
@Smidqe Smidqe marked this pull request as draft October 14, 2021 15:16
@Smidqe Smidqe force-pushed the refactor/player-modules branch from 3be3b11 to 3f4a2dd Compare October 18, 2021 18:27
@Smidqe Smidqe force-pushed the refactor/player-modules branch from 98740f5 to d2ab50c Compare November 13, 2021 09:04
@Smidqe Smidqe marked this pull request as ready for review November 13, 2021 09:05
@Smidqe Smidqe marked this pull request as draft November 13, 2021 09:18
@Smidqe Smidqe force-pushed the refactor/player-modules branch from d2ab50c to 4007050 Compare November 15, 2021 19:53
@Smidqe Smidqe force-pushed the refactor/player-modules branch from cdc59ef to d65bd9e Compare November 29, 2021 11:58
@Smidqe Smidqe force-pushed the refactor/player-modules branch from d65bd9e to 29c2517 Compare January 14, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant