-
Notifications
You must be signed in to change notification settings - Fork 9
Players: Modules and reworks #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Smidqe
wants to merge
34
commits into
BTDev:master
Choose a base branch
from
Smidqe:refactor/player-modules
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6cefa41 to
00c9187
Compare
ed23ebc to
2c661f8
Compare
3be3b11 to
3f4a2dd
Compare
98740f5 to
d2ab50c
Compare
d2ab50c to
4007050
Compare
cdc59ef to
d65bd9e
Compare
d65bd9e to
29c2517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent any breakage on the eve of anniversary games this pull request will stay as a draft until after it.
Reworked and made players into their own modules.
What's been tested:
What's not been tested (don't have setup atm):
Additions:
Changes:
PLAYERSnamespace toPlayers, not removingPLAYERSyet due to userspace (maltweaks) breakingRemovals:
Notes: