-
Notifications
You must be signed in to change notification settings - Fork 9
Feature: Chat images #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Atte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The img should probably call scrollBuffersToBottom() when the load event fires. Otherwise the chat buffer might not scroll properly, since the "message received" scroll happens before the image loads, and thus before the image has its final height.
There's also currently a /video filter, which creates a <video autoplay loop muted playsinline src="url" referrerpolicy="no-referrer" alt="Loading video..." onload="scrollBuffersToBottom()" /> instead of an <img ...>. Maybe the /img command coudld use the file extension to decide when to do that instead, so that the commands could be combined? Would be extra useful for weird stuff like ".gifv".
|
Would a combined |
|
Nah |
|
Oh right, forgot the aliases |
MERGE ONLY AFTER #84
Fixes #33
Aliases:
/img [image url]
/image [image url]
Will suppress the message if the link is not a valid or supported image.