Skip to content

Update write_svg to return svg string if not called with out_file #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FriederikeBiermann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update write_svg to return svg string if not called with out_file #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pikachu/drawing/drawing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,7 +1182,7 @@ def draw_svg(self, annotation: Union[None, str] = None, numbered_atoms: List = N
svg = self.assemble_svg()
return svg

def write_svg(self, out_file: str, annotation: Union[str, None] = None, numbered_atoms: List = None) -> None:
def write_svg(self, out_file: Union[str, None] = None, annotation: Union[str, None] = None, numbered_atoms: List = None) -> Union[str, None]:

self.flip_y_axis()
self.move_to_positive_coords()
Expand Down Expand Up @@ -1216,7 +1216,9 @@ def write_svg(self, out_file: str, annotation: Union[str, None] = None, numbered
svg_string += self.svg_style
svg_string += self.draw_svg(annotation=annotation, numbered_atoms=numbered_atoms)
svg_string += "</svg>"


if out_file is None:
return svg_string
with open(out_file, 'w') as out:
out.write(svg_string)

Expand Down