Create temporary path with boost::filesystem for cross platform compatibility

[kloudkl]

No description provided.

[kloudkl]

@jeffdonahue, what's your opinion?

[Yangqing]

LGTM.

[netheril96]

Both the old and new version have a potential race condition, because determining the temporary file name and opening it (the old one closes the file descriptor returned by mkstemp) is separate. This introduces the possibility that when the program opens the temporary file, it already exists and may either fail because of insufficient permissions, or cause security problems. The API of mkstemp is specifically designed to avoid this problem, an approach that should be adopted here. That is, instead of create a temporary file/directory name, just return a file descriptor or FILE*/DIR*.

[kloudkl]

@netheril96, Would you like to finish the task?

[netheril96]

@kloudkl Except that there is no easy way to implement the functionality of mkstemp in a cross platform manner. Neither boost or windows api exposes a similar function.

There sure is a way, given that Python has a mkstemp that is undoubtedly based on system API. But I don't know what it is.

[shelhamer]

Closing since there's still a race condition.