Skip to content

set up datum size for WindowDataLayer#1091

Merged
jeffdonahue merged 1 commit intoBVLC:devfrom
ronghanghu:fix_window_data_layer
Sep 16, 2014
Merged

set up datum size for WindowDataLayer#1091
jeffdonahue merged 1 commit intoBVLC:devfrom
ronghanghu:fix_window_data_layer

Conversation

@ronghanghu
Copy link
Member

set up datum size for WindowDataLayer to adapt for the new BaseDataLayer inferface.

otherwise, WindowDataLayer fails due to #1089

@sguada
Copy link
Contributor

sguada commented Sep 16, 2014

@ronghanghu could you check out my PR #1070 which I think it also fix this problem.
I think it doesn't make sense to have datum_* in base_data_layer.

@jeffdonahue
Copy link
Contributor

@sguada I agree, but I'll merge this since it's a 6 line change that makes WindowDataLayer usable in the short term -- let me also take a look at your PR though. Thanks for the fix @ronghanghu.

jeffdonahue added a commit that referenced this pull request Sep 16, 2014
set up datum size for WindowDataLayer
@jeffdonahue jeffdonahue merged commit 4b1f53c into BVLC:dev Sep 16, 2014
@ronghanghu ronghanghu deleted the fix_window_data_layer branch September 21, 2014 04:34
mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
RazvanRanca pushed a commit to RazvanRanca/caffe that referenced this pull request Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments