Fixed a memory leak issue in InternalThread (and removed caffe::Thread)#1335
Merged
shelhamer merged 2 commits intoBVLC:masterfrom Jan 16, 2015
Merged
Fixed a memory leak issue in InternalThread (and removed caffe::Thread)#1335shelhamer merged 2 commits intoBVLC:masterfrom
shelhamer merged 2 commits intoBVLC:masterfrom
Conversation
Member
|
I think that there should be a comment above the wrapper explaining its purpose. Otherwise it seems useless. I deleted it in my fork, not realizing that it had a use on other platforms. |
Member
|
Good idea. @ryotat please add a comment to explain the |
…n internal_thread.hpp.
Author
|
How about forward declaring boost::thread instead of using a wrapper class? Could someone try my commit 85477b7 if it compiles correctly on OSX? |
shelhamer
added a commit
that referenced
this pull request
Jan 16, 2015
Fix leaking thread and groom internal thread implementation.
Member
|
Thanks @ryotat -- forward declaration worked fine on OS X. I linted the code after merge, but please remember to do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the memory leak issue I posted here:
#1316 (comment)