Conversation
Contributor
Contributor
|
Hm, was about to merge but looks like the Python tests are failing? @longjon any idea why? Can't imagine it's actually related to the matcaffe changes... |
Contributor
|
Ok, I see now that the Python tests were failing at the merge of the PR adding those (https://travis-ci.org/BVLC/caffe/jobs/47889332), so I'll merge this. |
Member
This is my fault -- I forgot to update the Python tests in the back-merge that brought #1728 to dev. I'll fix it. Another reason to do away with dual branches... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix bugs by adding const to enable make matcaffe