Skip to content

Comments

leveldb iterator should be deleted before the db is deleted#1814

Closed
yzhliu wants to merge 1 commit intoBVLC:masterfrom
yzhliu:master
Closed

leveldb iterator should be deleted before the db is deleted#1814
yzhliu wants to merge 1 commit intoBVLC:masterfrom
yzhliu:master

Conversation

@yzhliu
Copy link

@yzhliu yzhliu commented Jan 29, 2015

In some old version of leveldb, the iterator must be deleted before the db. Otherwise, it will cause a failure like:

compute_image_mean: version_set.cc:715: leveldb::VersionSet::~VersionSet(): Assertion `dummy_versions_.next_ == &dummy_versions_' failed.
./compute-mean.sh: line 2: 26811 Aborted ./build/tools/compute_image_mean train_leveldb mean.binaryproto leveldb

This is what I got on centos-6.5, rhel-6.5, with epel6 - leveldb-1.7.0-2.el6
Someone else had encountered the same problem, see https://groups.google.com/forum/#!topic/leveldb/I0_gN82a3vI

@shelhamer
Copy link
Member

@Javelinjs can you check if this is addressed by #1748? If so this will be fixed once that is merged (soon).

@longjon
Copy link
Contributor

longjon commented Jan 30, 2015

Should work fine in #1748 on account of automatic destructor order, but let me know if you think otherwise @Javelinjs.

@yzhliu
Copy link
Author

yzhliu commented Jan 30, 2015

@shelhamer @longjon I think it works, just ignore this PR, thanks.

@shelhamer
Copy link
Member

Closing as fixed by #1748. Thanks for submitting a patch and checking @Javelinjs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants