Bug in MemoryData that does not allow using arrays with n_ * size_ > 2^31#1838
Merged
Bug in MemoryData that does not allow using arrays with n_ * size_ > 2^31#1838
Conversation
Contributor
|
Thanks for the fix; only issue is this should probably be |
uint64_t size_t
Contributor
Author
|
Done |
Contributor
|
Thanks! |
longjon
added a commit
that referenced
this pull request
Feb 9, 2015
Bug in MemoryData that does not allow using arrays with n_ * size_ > 2^31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the problem is in here:
pos_andsize_areint, so I had segmentation fault due to overflow in there, I think, when using huge array. To overcome this we need to change some variables types, so please comment how you think to do it better since I did the first thing that came to my mind that would fix the crashes I had.