solver.cpp: call UpgradeNetAsNeeded() on learned_net in Solver::Restore()#1972
Closed
moskewcz wants to merge 1 commit intoBVLC:masterfrom
Closed
solver.cpp: call UpgradeNetAsNeeded() on learned_net in Solver::Restore()#1972moskewcz wants to merge 1 commit intoBVLC:masterfrom
moskewcz wants to merge 1 commit intoBVLC:masterfrom
Conversation
jeffdonahue
added a commit
that referenced
this pull request
Mar 13, 2015
Use ReadNetParamsFromBinaryFileOrDie to read a net param when restoring from a saved solverstate, which upgrades old nets, rather than ReadProtoFromBinaryFile.
Contributor
matthiasplappert
pushed a commit
to matthiasplappert/caffe
that referenced
this pull request
Aug 10, 2015
Use ReadNetParamsFromBinaryFileOrDie to read a net param when restoring from a saved solverstate, which upgrades old nets, rather than ReadProtoFromBinaryFile.
cbfinn
pushed a commit
to cbfinn/caffe
that referenced
this pull request
Aug 12, 2015
Use ReadNetParamsFromBinaryFileOrDie to read a net param when restoring from a saved solverstate, which upgrades old nets, rather than ReadProtoFromBinaryFile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when resuming training using the --snapshot option, and thus loading .solverstate files, it seems caffe will load the linked-to .caffemodel file without calling UpgradeNetAsNeeded() on the loaded net as it does elsewhere. this seems to cause the resultant loaded net to be (silently) garbage in the case where the linked-to prototxt needed an upgrade. perhaps we want to do something like this? i guess this is only an issue for resuming 'old' training runs, which might not in general be supported. but if it's not to be supported, perhaps it should be error-checked somehow? and perhaps even if it's generally unsupported this feature/fix might be wanted.