Adapt python net drawing to new proto format#1984
Adapt python net drawing to new proto format#1984axel-angel wants to merge 1 commit intoBVLC:masterfrom axel-angel:master
Conversation
|
@axel-angel thanks for checking this but this change is actually in reverse. The current code is right as layer type has changed to a string #1694. The examples should all be in this new format. @jeffdonahue is there old proto somewhere? |
|
Okay then, that would explain why I have a deprecation warning(1). I need to adapt my prototxt to the new format then, I'll look into it. I had the case where "layers" were not recognized and thus I switched to "layer" and such, and that's probably due to my repository not updated to last version (seems the modification went the 5th February). Thank you for the clarification! (1)
|
|
The problem is the protobuf itself does not support automatically updating old format. Should we add something to prohibit to draw old format protofile? I think no message is not good. Otherwise, merge layrers and layer after reading net proto? |
The current version of draw_net.py that's using draw.py plots an empty figure on the LeNet prototxt. I've heard the format of this file changed/is changing and thus I made the adaptation that works.
Can you review this?