Add more convenience math functions and all tests pass#201
Conversation
|
Thanks for the fixed PR! Checked that this builds and that tests pass. Please run |
|
All the lint errors except two about the CUDA kernel launch operator (linter wrongly takes <<< in macro definition as <<) have been fixed. |
There was a problem hiding this comment.
Add // NOLINT_NEXT_LINE(whitespace/operators) to the line above to grant an exception for the CUDA <<< and >>>. See https://github.com/BVLC/caffe/blob/dev/src/caffe/layers/pooling_layer.cu#L149 for an example.
|
I plan to merge this soon after #165, which is first since it is an older effort and broadens compatibility. This PR will need to be rebased then (it is not a clean merge now, either). |
|
Yes, I am dealing with the trouble of a bunch of merge conflicts with dev. |
|
Rebased, cpplinted and tested. Ready for merging. |
Add more convenience math functions and all tests pass
|
Thanks @kloudkl! |
Add more convenience math functions and all tests pass
Reshape algorithm fixed
This PR fixed the build error in #159 and removed the code that might conflict with #161.
Two lessons learned: