Always call Layer::Reshape in Layer::Forward#2165
Merged
jeffdonahue merged 1 commit intoBVLC:masterfrom May 14, 2015
Merged
Conversation
There are no cases where Forward is called without Reshape, so we can simplify the call structure.
weiliu89
added a commit
to weiliu89/caffe
that referenced
this pull request
Apr 14, 2015
Always call Layer::Reshape in Layer::Forward
Contributor
|
LGTM, thanks for the simplification. |
jeffdonahue
added a commit
that referenced
this pull request
May 14, 2015
Always call Layer::Reshape in Layer::Forward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no cases where
Forwardis called withoutReshape, so we can simplify the call structure. This will also simplify a future PR.