Closed
Conversation
Contributor
Author
|
Is there anything else that should be done for this pull request? |
Closed
kevinbache
force-pushed
the
adadelta
branch
2 times, most recently
from
2d01607 to
e5a2972
Compare
Contributor
Author
|
No problem. I ended up just squashing all of mine -- seemed to make the most sense. Please let me know if there's anything else I should do! |
Contributor
|
I'm interested in the Ada Delta solver. Is this change likely going to make it into master anytime soon? |
Merged
Member
|
Carried on in #2782 -- sorry for the wait on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor update to #1122. It brings @mohomran's AdaDelta solver into sync with modern Caffe and fixes the slow tests mentioned in #1122 by reducing the number of iterations for multi-iter tests from 500 down to 4 (as with the Nesterov tests). All tests pass and take a normal amount of time.