Conversation
Allow initialize transformed_blob from datum or transform params. Allow force_color and force_gray as transform params.
Contributor
|
Thanks for the refactor @sguada! LGTM. |
Contributor
|
Travis' merge build failed due to the LMDB download failure, as reported by @ronghanghu in #2527 (comment). We'll have to find a more reliable download URL for LMDB...I think we changed to the current one because the previous one was causing our build to fail as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Data_Transform to be able to estimate the Blob sizes after transforming Datum. This simplify the Data Layers and will allow to do more transformations when using encoded Datum.
Having replicated code across Data Layers and Data_Transform to estimate Blob sizes makes hard to add new transformation, like resize the image to have an specific small size.
@longjon @shelhamer Please take a look at let me know
@cypof I think this should help with the IO