Fix matcaffe init_key initialization#2562
Closed
ronghanghu wants to merge 1 commit intoBVLC:masterfrom
Closed
Conversation
Previously in matcaffe, init_key is initialized with caffe_rng_rand(). However, caffe_rng_rand() relies on shared_ptr<Caffe> Caffe::singleton_ (in common.hpp), and there is no guarantee in C++ that Caffe::singleton_ will be constructed before init_key is initialized. Instead of generating random init_key at the beginning, use a constant number (-2.) for its first value.
ronghanghu
force-pushed
the
fix-matcaffe-initkey
branch
from
89e91ee to
6b46e56
Compare
woozzu
added a commit
to woozzu/caffe
that referenced
this pull request
Jul 27, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in matcaffe (#2505),
init_keyis initialized withcaffe_rng_rand(). However,caffe_rng_rand()relies onstatic shared_ptr<Caffe> Caffe::singleton_(in common.hpp), and there is no guarantee in C++ thatCaffe::singleton_will be constructed beforeinit_keyis initialized.Although current implementation work with g++, it may break with other compilers. Instead of generating random init_key at the beginning, use a constant number (-2.) for its first value.