Closed
Conversation
Contributor
|
A simple parameter string seems to be a good solution. I would still add a comment recommending a particular way of passing parameters ( JSON seems suitable ) as the default, just to minimize unnecessary work of dealing with different formats. @longjon does this sufficiently solve the second last point of #1376? |
Member
There was a problem hiding this comment.
This is adding an arguments property to all Layers and not just PythonLayer.
Member
|
Thanks for contributing your own version of parameter passing to Python layers, but I'm closing this in favor of the original change by @tnarihi. The change here incorrectly introduces a new property for all layers. See #2871 for the cherry-picking of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a way for PythonLayers (#1703) to accept arguments through prototxt files.
Instead of loading files or other processing in
setup(), this allows one to pass parameters through the 'arguments' string in PythonParameter. The receiver can then process the string however they choose: load throughjson.loads(), comma separated values, etc.This pull request is a simpler alternative to #2001, without exception handling changes.
Example class:
Example addition to prototxt:
layer { name: "python1" type: "Python" bottom: "prev1" top: "curr1" python_param { module: "multlayer" layer: "MultLayer" arguments: "10" } }