Log error strings in the error/status checking macros#278
Merged
jeffdonahue merged 6 commits intoBVLC:devfrom Apr 2, 2014
kloudkl:log_error_string_in_check_macro
Merged
Log error strings in the error/status checking macros#278jeffdonahue merged 6 commits intoBVLC:devfrom kloudkl:log_error_string_in_check_macro
jeffdonahue merged 6 commits intoBVLC:devfrom
kloudkl:log_error_string_in_check_macro
Conversation
Contributor
There was a problem hiding this comment.
Why the do { ... } while (0)? Wouldn't just { ... } work?
Member
There was a problem hiding this comment.
do/whiles in C++ macros are an ugly corner of the language.
Contributor
There was a problem hiding this comment.
ah, how annoying. Thanks for the explanation.
Contributor
|
Thanks @kloudkl! Please rebase and we can merge. |
Contributor
Author
|
Rebased. |
jeffdonahue
added a commit
that referenced
this pull request
Apr 2, 2014
Log error strings in the error/status checking macros
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Log error strings in the error/status checking macros
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error strings are much more meaningful for debugging than the raw enum values.