Fix SPPLayer top blob num and address pyramid_height_ == 1#2970
Merged
ronghanghu merged 1 commit intoBVLC:masterfrom Aug 26, 2015
Merged
Fix SPPLayer top blob num and address pyramid_height_ == 1#2970ronghanghu merged 1 commit intoBVLC:masterfrom
pyramid_height_ == 1#2970ronghanghu merged 1 commit intoBVLC:masterfrom
Conversation
747c9d0 to
9d79e4a
Compare
…==1 in SPPLayer also, do nothing in SPPLayer Reshape if already reshaped once and bottom size unchanged
ronghanghu
added a commit
that referenced
this pull request
Aug 26, 2015
Fix SPPLayer top blob num and address `pyramid_height_ == 1`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
pyramid_height_ == 1. This is equivalent to max-pooling over the entire bottom, similar to what ReductionLayer does but with a MAX operation. Previouslypyramid_height_ == 1case crashes.