Skip to content

Comments

Fix SPPLayer top blob num and address pyramid_height_ == 1#2970

Merged
ronghanghu merged 1 commit intoBVLC:masterfrom
ronghanghu:spp-fix
Aug 26, 2015
Merged

Fix SPPLayer top blob num and address pyramid_height_ == 1#2970
ronghanghu merged 1 commit intoBVLC:masterfrom
ronghanghu:spp-fix

Conversation

@ronghanghu
Copy link
Member

This PR

  • fixes previous mistake in SPPLayer, restricting top blob num to be exact 1. (Perviously top blob num can be 2 for outputting max index, but that's never implemented at all).
  • addresses for the case that pyramid_height_ == 1. This is equivalent to max-pooling over the entire bottom, similar to what ReductionLayer does but with a MAX operation. Previously pyramid_height_ == 1 case crashes.
  • reshape only when bottom shape is changed, since it involve destroying and re-constructing inner layers.

…==1 in SPPLayer

also, do nothing in SPPLayer Reshape if already reshaped once and bottom size unchanged
ronghanghu added a commit that referenced this pull request Aug 26, 2015
Fix SPPLayer top blob num and address `pyramid_height_ == 1`
@ronghanghu ronghanghu merged commit b7e4bfe into BVLC:master Aug 26, 2015
@ronghanghu ronghanghu deleted the spp-fix branch August 26, 2015 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant