Merged
Conversation
include/caffe/loss_layers.hpp
Outdated
Contributor
There was a problem hiding this comment.
I think this is correct? (See https://github.com/BVLC/caffe/blob/master/src/caffe/proto/caffe.proto#L414)
Contributor
Author
There was a problem hiding this comment.
You're right, that documentation is correct. I was misreading it, sorry. It's actually the @copydoc SoftmaxWithLossLayer in Forward_cpu that triggers the doxygen warning.
I can update the PR with the doc for Forward_cpu removed as I don't think the same docs make sense in Forward_cpu.
Contributor
There was a problem hiding this comment.
Sure, makes sense to remove the copydoc. Thanks!
darrengarvey
force-pushed
the
cleanup-documentation-warnings
branch
from
68d0ae4 to
19b18be
Compare
Fix some doxygen warnings about an undocumented argument in Blob and incorrect documentation for SoftmaxWithLossLayer::Forward_cpu().
darrengarvey
force-pushed
the
cleanup-documentation-warnings
branch
from
19b18be to
6f5812c
Compare
jeffdonahue
added a commit
that referenced
this pull request
Sep 2, 2015
…ings Fix up documentation errors.
Contributor
|
Thanks @darrengarvey! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some doxygen warnings about an undocumented argument in Blob and
incorrect documentation in a constructor of SoftmaxWithLossLayer.