Cmake add version and soversion#3015
Closed
cdluminate wants to merge 2 commits intoBVLC:masterfrom
cdluminate:cmake-add-version-and-soversion
Closed
Cmake add version and soversion#3015cdluminate wants to merge 2 commits intoBVLC:masterfrom cdluminate:cmake-add-version-and-soversion
cdluminate wants to merge 2 commits intoBVLC:masterfrom
cdluminate:cmake-add-version-and-soversion
Conversation
Contributor
|
I would like to see all of these things together in one patch:
I started working on this but had to abandon it for something else. Feel free to steal some of this if anything is helpful: |
Contributor
|
Also, you could update the summary to print the version: |
Member
|
Thanks for submitting this @cdluminate but let's focus on the complete patch by @lukeyeager in #3311. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed CMake files in order to add SONAME for libcaffe.so.
Adding SONAME would be convenient for Distribution maintainers to maintain a package.
This patch is derived from debian packaging repo of caffe.
Please have a look at it, thanks.