Enables the alternate solvers to be accessed by the python interface.#3024
Enables the alternate solvers to be accessed by the python interface.#3024shelhamer merged 1 commit intoBVLC:masterfrom
Conversation
|
Thanks for including more solvers @danielgordon10, but please revise to add |
|
I'll note that the other solvers can already be accessed by |
|
@jeffdonahue right -- I'm fine with either exposing them all like this or documenting the use of |
|
@shelhamer Whoops, totally missed that one. |
|
Either way, I'm pretty sure the NesterovSolver and AdaGradSolver lines in _caffe.cpp were uncallable without a change. So something needs to be done. |
|
Anyone know what the build fail is about? |
|
From the travis log: which blame points to 374fb8c in #2935. @ronghanghu could you check what this is about? @danielgordon10 the test failure has nothing to do with your PR, so don't worry about that. However do squash your fixup commit for AdaDelta for a clear history. Thanks. |
|
@shelhamer I'll checkout shortly. |
|
@shelhamer There is a bug with AccuracyLayer test in #2935 which I didn't observe. It was my fault. I made a fix PR in #3027. |
|
@shelhamer Is there an easy way to squash the commits into an already pushed branch? I'm having issues pushing the squashed version saying I'm behind the pushed one. And if I pull first, then I have a bunch of commits, which is exactly what squash is trying to avoid. |
|
@danielgordon10 once you squash, force push by |
3929f85 to
5cc76ad
Compare
|
@shelhamer naughty naughty, using -f. I'll do it, but I won't enjoy it. |
|
Not at all -- "published history" in the sense of the project is the canonical BVLC/caffe master branch. Force push is not only fine but right to wrap up PRs. |
[pycaffe] expose all solvers for direct instantiation (although note get_solver)
No description provided.