Add Optional AudioDataLayer and LibSndFile Dependancy#3065
Closed
aidangomez wants to merge 7 commits intoBVLC:masterfrom
Closed
Add Optional AudioDataLayer and LibSndFile Dependancy#3065aidangomez wants to merge 7 commits intoBVLC:masterfrom
aidangomez wants to merge 7 commits intoBVLC:masterfrom
Conversation
aidangomez
force-pushed
the
AudioDataLayer
branch
8 times, most recently
from
7dd6c87 to
6ca07bb
Compare
aidangomez
changed the title
aidangomez
force-pushed
the
AudioDataLayer
branch
21 times, most recently
from
bfbec26 to
6b39ea0
Compare
aidangomez
force-pushed
the
AudioDataLayer
branch
18 times, most recently
from
e3482ee to
0dc6d21
Compare
aidangomez
force-pushed
the
AudioDataLayer
branch
2 times, most recently
from
f4b65b8 to
aa1aad2
Compare
aidangomez
force-pushed
the
AudioDataLayer
branch
from
aa1aad2 to
e4c7c79
Compare
Member
|
Closing as better handled by a Python data layer. While I do appreciate the extension to audio, the further dependencies and amount of code make me wary. Sorry for the long wait and that my initial review didn't flag these issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional use Audio Data using the familiar functionality of Image Data. This will allow users to import audio data in a similar manner to ImageDataLayer (text file with " \n" format) at the expense of the barebones and widely supported C library "LibSndFile".
Modifications:
Planned extensions: