Fix broken DeconvolutionLayer GPU backward caused by ND conv typo#3095
Fix broken DeconvolutionLayer GPU backward caused by ND conv typo#3095jeffdonahue merged 1 commit intoBVLC:masterfrom
Conversation
|
Yikes! Thanks for the fix. Looking quickly (since I want to merge ASAP) I don't understand why the buggy version passes the current gradient checks...it seems like they shouldn't pass unless we were only testing the |
Fix broken DeconvolutionLayer GPU backward caused by ND conv typo
|
@jeffdonahue @longjon It is clearly good that the indexing of the top diff is fixed so that deconv is correct in all cases, but oddly enough the code was correct as it was when doing backprop to both params and bottoms according to All-in-all this was subtle and weird but not completely broken. However, we should consider test coverage of different |
#2049 broke deconvolution GPU backward with a typo (https://github.com/BVLC/caffe/pull/2049/files#diff-5911f1d28796ada5f80449e8bd05d270R54 omits the
n *coefficient). This PR fixes.This should really really be covered by the tests, but this PR is just the fix for master.