Merged
Conversation
shelhamer
force-pushed
the
net-init-logging
branch
3 times, most recently
from
eeda081 to
bd27899
Compare
src/caffe/net.cpp
Outdated
Member
There was a problem hiding this comment.
You seem to have removed a necessary } here.
- condense conditions by `LOG_IF` - only log memory use once after all tops
shelhamer
force-pushed
the
net-init-logging
branch
from
bd27899 to
6f8370a
Compare
shelhamer
added a commit
that referenced
this pull request
Oct 17, 2015
[style] Clean Up Logging for Net Init
Member
Author
|
Dropping the memory usage log line is fine by me. It does cause confusion Evan Shelhamer On Mon, Oct 19, 2015 at 7:53 PM, Sean Bell notifications@github.com wrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LOG_IFComment to vote for the current memory usage logging if there's a use case out there.