Detect division by zero#3238
Open
dblN wants to merge 1 commit intoBVLC:masterfrom
dblN:detect-division-by-zero
Open
Detect division by zero#3238dblN wants to merge 1 commit intoBVLC:masterfrom dblN:detect-division-by-zero
dblN wants to merge 1 commit intoBVLC:masterfrom
dblN:detect-division-by-zero
Conversation
Member
Contributor
|
/cc @mtamburrano |
Contributor
|
@ronghanghu We could always improve that if somebody had given us any review feedbacks by months. This one got a reply only after 5 days. See also BAIDU researcher catch almost ignored at #2623 and related PR at #2569. |
Contributor
|
hi @ronghanghu, |
Contributor
|
/cc @prclibo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There happens division by zero if the setting is inappropriate.
stepsizeis not specified, it can be 0.I added checks for these cases.