fix a bug that time duration may be 0 when downloading model binary#3313
Merged
shelhamer merged 1 commit intoBVLC:masterfrom Dec 2, 2015
Merged
fix a bug that time duration may be 0 when downloading model binary#3313shelhamer merged 1 commit intoBVLC:masterfrom
shelhamer merged 1 commit intoBVLC:masterfrom
Conversation
shelhamer
added a commit
that referenced
this pull request
Dec 2, 2015
don't divide by 0 duration when downloading model binary
Member
|
Thanks -- this doesn't seem like a common issue but it doesn't hurt to avoid it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes urllib calls a hook the first time and then the second in a time distance too shorter than 1 second, in which case
download_model_binary.pywill break. This commit fixes this crash.Extra information:
scripts/download_model_binary.pyto download caffe model, it once reported;countwas about 6 KB.