replace snprintf with a C++98 equivalent#3361
Merged
ronghanghu merged 1 commit intoBVLC:masterfrom Nov 27, 2015
BonsaiAI:avoid-snprintf
Merged
replace snprintf with a C++98 equivalent#3361ronghanghu merged 1 commit intoBVLC:masterfrom BonsaiAI:avoid-snprintf
ronghanghu merged 1 commit intoBVLC:masterfrom
BonsaiAI:avoid-snprintf
Conversation
Member
|
IMHO Note: Microsoft has finally implemented |
Contributor
Author
|
@ronghanghu specifically, |
Contributor
Author
|
Opinions on this PR? |
Member
|
This all looks good to me. I'll try to review during the Thanksgiving (got a bit overwhelmed myself these days since it is near the end of the semester). |
Contributor
Author
|
@ronghanghu thanks! Don't forget to relax during holidays. |
ronghanghu
added a commit
that referenced
this pull request
Nov 27, 2015
replace snprintf with a C++98 equivalent
Member
|
Thanks @eelstork ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snprintfis not consistently available on Windows.Although patchy support is possible (search snprintf in suggested reference), I find that
snprintfmay be advantageously replaced by a solution which doesn't involve defining arbitrarily sized buffers and converting between C and C++ strings.As I understand that C++ streams are not very popular and the main use of
snprintfin Caffe is producing numbered batches, I suggest the introduction of a utility function (format_int).