Make popcount cross-platform#3402
Closed
eelstork wants to merge 1 commit intoBVLC:masterfrom
BonsaiAI:popcount-compatibility
Closed
Make popcount cross-platform#3402eelstork wants to merge 1 commit intoBVLC:masterfrom BonsaiAI:popcount-compatibility
eelstork wants to merge 1 commit intoBVLC:masterfrom
BonsaiAI:popcount-compatibility
Conversation
Member
|
I guess you don't need this one. You can perhaps just remove Actually I don't think you need |
This was referenced Dec 2, 2015
Contributor
|
Obsoleted by #3404. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__builtin__popcountis a built-in GCC function. There is no standard C/C++ equivalent.For portability I provide an explicit popcount implementation; for performance on Windows, MSVC built-ins are suggested.
Compiler specific code may be avoided; should we make an exception in this case?
Implementation note
_GNUC_is also defined with llvm/clang; testing for__llvm__and/or__clang__will not behave as expected. Less naive compiler macros might be used (at the cost of adding Boost headers).Currently pop count is only used in
hamming_distance; It would appear that Caffe does not use this function.