Make CheckGradientExhaustive fail for topless layers#350
Merged
Conversation
Without this commit, it is possible to mistakenly call CheckGradientExhaustive on a layer with no top blobs (i.e., a loss layer), causing the gradient check to silently succeed while doing nothing. With this commit, doing so will cause the test to fail.
Member
|
Good safeguard against silent mistakes. Thanks Jon. |
shelhamer
added a commit
that referenced
this pull request
Apr 22, 2014
Make CheckGradientExhaustive fail for topless layers
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Make CheckGradientExhaustive fail for topless layers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this commit, it is possible to mistakenly call CheckGradientExhaustive on a layer with no top blobs (i.e., a loss layer), causing the gradient check to silently succeed while doing nothing. With this commit, doing so will cause the test to fail.
All existing tests continue to pass.
See, e.g., @aravindhm's comment in #258.