Handle signals with boost Asio#3500
Open
eelstork wants to merge 1 commit intoBVLC:masterfrom
BonsaiAI:x-platform-signal-handling
Open
Handle signals with boost Asio#3500eelstork wants to merge 1 commit intoBVLC:masterfrom BonsaiAI:x-platform-signal-handling
eelstork wants to merge 1 commit intoBVLC:masterfrom
BonsaiAI:x-platform-signal-handling
Conversation
Contributor
|
I'm not ready to review in detail, but this looks like like a good direction; we already have a strong boost dependency, and this seems to simplify the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referring #2253 and #2012, signal handling was implemented in Caffe using
sigaction. I suggest a cross platform implementation.@willyd proposed using Boost Asio to make signal handling more cross platform.
@ronghanghu as you were involved in testing the original implementation, would you please have a look at this?