Closed
Conversation
Contributor
|
Your fix doesn't seem to work on TravisCI (Ubuntu 12.04). This comment might be relevant/helpful:
|
Fixes for building and installing via CMake
Author
|
hacking away at the issue.. p sure I know what the problem is; please hold and I'll push a fix :) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed working for both OS X (El Capitan) and Linux (Ubuntu LTS)
This fixes #3597 and fixes #3459.
About the Linux dynamic linking setup.. perhaps it would be better practice if we added libcaffe to the OS's dynamic library cache? We could do something like this:
So, it works well right now using
ld.so'smagic '$ORIGIN' variable, but maybe switching toldconfigis the right move. Any preference? Let me know! :)