bugfix for incorrect behaviour in caffe_parse_linker_libs#3650
Merged
jeffdonahue merged 1 commit intoBVLC:masterfrom Feb 9, 2016
abhijitkundu:cmake-matlab-fix
Merged
bugfix for incorrect behaviour in caffe_parse_linker_libs#3650jeffdonahue merged 1 commit intoBVLC:masterfrom abhijitkundu:cmake-matlab-fix
caffe_parse_linker_libs#3650jeffdonahue merged 1 commit intoBVLC:masterfrom
abhijitkundu:cmake-matlab-fix
Conversation
…ile extracting libflags from absolute library path with multiple (dots)
|
LGTM It replaces cmake file extension removal function with own code to get proper behavior: |
Contributor
|
Thanks @intbots and @Nerei for the review! |
jeffdonahue
added a commit
that referenced
this pull request
Feb 9, 2016
bugfix for incorrect behaviour in `caffe_parse_linker_libs`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugfix for incorrect behaviour in
caffe_parse_linker_libsfunction while extracting libflags from absolute library path with multiple (dots)On Ubuntu (both on 14.04 and 15.10) using cmake to build matlab wrapper gives a
Cannot find -lpython2error. See here.This is because
caffe_parse_linker_libsconverts an absolute library path like/usr/lib/x86_64-linux-gnu/libpython2.7.soto-lpython2The attached change will correctly convert
/usr/lib/x86_64-linux-gnu/libpython2.7.soto-lpython2.7