CMake: Do not include "${PROJECT_BINARY_DIR}/include" with SYSTEM option#3715
Merged
shelhamer merged 1 commit intoBVLC:masterfrom Feb 25, 2016
Merged
CMake: Do not include "${PROJECT_BINARY_DIR}/include" with SYSTEM option#3715shelhamer merged 1 commit intoBVLC:masterfrom
shelhamer merged 1 commit intoBVLC:masterfrom
Conversation
This is important for the include order. Without this patch, a previously installed caffe.pb.h might be included instead of the one that is generated during the build.
Member
|
Yes. that's right patch. I came from copypast and that I didn't take this into account that caffe may be installed to system paths. LTGM |
shelhamer
added a commit
that referenced
this pull request
Feb 25, 2016
CMake: Do not include "${PROJECT_BINARY_DIR}/include" with SYSTEM option
fxbit
pushed a commit
to Yodigram/caffe
that referenced
this pull request
Sep 1, 2016
CMake: Do not include "${PROJECT_BINARY_DIR}/include" with SYSTEM option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is important for the include order. Without this patch, a
previously installed caffe.pb.h might be included instead of the one
that is generated during the build.