Merged
Conversation
output info, warnings, and errors for fuller description of the upgrade
check all conditions all the time; V0 -> V1 and V1 -> V2 do not suffice.
convert inputs in legacy definitions (prototxt), but simply strip inputs from legacy weights (caffemodel). fix BVLC#3750
die loudly if a net definition (prototxt) mixes proto formats by defining both `layer` and `layers` fields instead of complaining but discarding and continuing. fix BVLC#3381
shelhamer
referenced
this pull request
Mar 1, 2016
Member
Author
|
I'm going ahead and merging this since a number of users have run into this issue -- whether to die on mixed version definitions can be amended later if we decide against it. |
shelhamer
added a commit
that referenced
this pull request
Mar 1, 2016
Member
Author
|
Follow-ups:
|
fxbit
pushed a commit
to Yodigram/caffe
that referenced
this pull request
Sep 1, 2016
Fix Upgrade Net Tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jeffdonahue any thoughts on the harsher reaction of #3381? I think it is safer and more explicit about the issue.