Skip to content

Layer definitions and declarations re-organization and documentation#376

Merged
sergeyk merged 7 commits intoBVLC:devfrom
sergeyk:layer_reorg
May 19, 2014
Merged

Layer definitions and declarations re-organization and documentation#376
sergeyk merged 7 commits intoBVLC:devfrom
sergeyk:layer_reorg

Conversation

@sergeyk
Copy link
Contributor

@sergeyk sergeyk commented Apr 29, 2014

The goal is to have a more readable and easily navigable codebase (concerning layer definitions/declarations):

  • Split parts of vision_layers.hpp into loss_layers.hpp, data_layers.hpp, and neuron_layers.hpp.
  • Add LossLayer for cleaner inheritance
  • Split loss layer implementations into own .cpp files
  • Concise documentation of each Layer in the header files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Popular in auto-encoders.

@shelhamer
Copy link
Member

Thanks for the arranging and documenting! Once this is done we should do another release–it's been over a month and dev bears so many gifts.

@sergeyk
Copy link
Contributor Author

sergeyk commented May 19, 2014

The docstrings aren't all there, but let's get this into dev and follow up with small commits with docs later.

@sergeyk sergeyk changed the title [WIP] Layer definitions and declarations re-organization and documentation Layer definitions and declarations re-organization and documentation May 19, 2014
sergeyk added a commit that referenced this pull request May 19, 2014
Layer definitions and declarations re-organization and documentation
@sergeyk sergeyk merged commit 8534541 into BVLC:dev May 19, 2014
@shelhamer shelhamer mentioned this pull request May 20, 2014
mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
Layer definitions and declarations re-organization and documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments