Only check the dimensions start from start_axis#3778
Closed
wk910930 wants to merge 1 commit intoBVLC:masterfrom
wk910930:move-CHECK_GE
Closed
Only check the dimensions start from start_axis#3778wk910930 wants to merge 1 commit intoBVLC:masterfrom wk910930:move-CHECK_GE
wk910930 wants to merge 1 commit intoBVLC:masterfrom
wk910930:move-CHECK_GE
Conversation
* The dimensions before start_axis is okay to have its own size but might not pass the check
|
+1, I also need this! The present code in the master branch does not allow different numbers of channels for the two input blobs even when only the spatial dimensions are cropped. This does not affect the original FCN models but is obstructive when implementing models like in the hypercolumn paper. I've yet to do more testing but for now this pull request seems to work for me. Edit: #3993 has been merged so this is probably obsolete |
Member
|
@wk910930 Sorry, you're totally right! Thanks for this and thanks @MalteOeljeklaus for confirming. This was fixed in #3993. Sorry again that this was lost in the deadline whirlwind of March. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crop_offset may not be suitable or needed for dimensions before start_axis.